Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: add timers to SS/USSD test cases

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 14 21:50:02 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14457 )

Change subject: MSC_Tests.ttcn: add timers to SS/USSD test cases
......................................................................

MSC_Tests.ttcn: add timers to SS/USSD test cases

Change-Id: I1883bae34a9fe0435a6138cb7594461dee3bb232
---
M msc/MSC_Tests.ttcn
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index c57328f..b66323b 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2820,13 +2820,18 @@
 private function f_expect_gsup_msg(template GSUP_PDU msg)
 runs on BSC_ConnHdlr return GSUP_PDU {
 	var GSUP_PDU gsup_msg_complete;
+	timer T := 2.0;
 
+	T.start;
 	alt {
 	[] GSUP.receive(msg) -> value gsup_msg_complete {
 		setverdict(pass);
 		}
 	/* We don't expect anything else */
 	[] as_unexp_gsup_or_bssap_msg();
+	[] T.timeout {
+		setverdict(fail, "Timeout waiting for GSUP message: ", msg);
+		}
 	}
 
 	return gsup_msg_complete;
@@ -2835,13 +2840,18 @@
 private function f_expect_mt_dtap_msg(template PDU_ML3_NW_MS msg)
 runs on BSC_ConnHdlr return PDU_ML3_NW_MS {
 	var PDU_DTAP_MT bssap_msg_complete;
+	timer T := 2.0;
 
+	T.start;
 	alt {
 	[] BSSAP.receive(tr_PDU_DTAP_MT(msg)) -> value bssap_msg_complete {
 		setverdict(pass);
 		}
 	/* We don't expect anything else */
 	[] as_unexp_gsup_or_bssap_msg();
+	[] T.timeout {
+		setverdict(fail, "Timeout waiting for BSSAP message: ", msg);
+		}
 	}
 
 	return bssap_msg_complete.dtap;
@@ -2928,6 +2938,8 @@
 /* LU followed by MT USSD notification */
 friend function f_tc_lu_and_mt_ussd_notification(charstring id, BSC_ConnHdlrPars pars)
 runs on BSC_ConnHdlr {
+	timer T := 5.0;
+
 	f_init_handler(pars);
 
 	/* Perform location update */
@@ -2967,6 +2979,7 @@
 
 	/* Send it to MSC and expect Paging Request */
 	GSUP.send(gsup_req);
+	T.start;
 	alt {
 	[pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {
 		setverdict(pass);
@@ -2976,6 +2989,9 @@
 		}
 	/* We don't expect anything else */
 	[] as_unexp_gsup_or_bssap_msg();
+	[] T.timeout {
+		setverdict(fail, "Timeout waiting for Paging Request");
+		}
 	}
 
 	/* Send Paging Response and expect USSD notification */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1883bae34a9fe0435a6138cb7594461dee3bb232
Gerrit-Change-Number: 14457
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/71ca10be/attachment.html>


More information about the gerrit-log mailing list