Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 14 16:38:56 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 )

Change subject: libvlr: fix sgsn tmsi creation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c 
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c@339 
PS1, Line 339: 0xC0000000
> Nice catch of course, but where does this magic constant comes  from? I also see it's used in OsmoSG […]
Indeed, we should add this to include/osmocom/gsm/protocol/gms_23003.h and then use it here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba
Gerrit-Change-Number: 14448
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 14 Jun 2019 16:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/49fcc397/attachment.html>


More information about the gerrit-log mailing list