Change in ...libosmocore[master]: fsm.c: Print error message for FSM with allstate_action but no events

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jun 14 15:39:07 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14361 )

Change subject: fsm.c: Print error message for FSM with allstate_action but no events
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/14361/2/src/fsm.c 
File src/fsm.c:

https://gerrit.osmocom.org/#/c/14361/2/src/fsm.c@260 
PS2, Line 260: 	if (fsm->allstate_action && !fsm->allstate_event_mask)
Probably, vice versa too, i.e. allstate_event_mask != 0x00 and allstate_action == NULL.


https://gerrit.osmocom.org/#/c/14361/2/src/fsm.c@261 
PS2, Line 261: ,f
cosmetic: space is missing



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9e73f7363ab15a00843e3f0d1e5776f4be7ebc46
Gerrit-Change-Number: 14361
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 15:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/affa57be/attachment.html>


More information about the gerrit-log mailing list