Change in ...libosmocore[master]: vty: command.c: Fix: multi-choice args are no longer passed incomplet...

pespin gerrit-no-reply at lists.osmocom.org
Fri Jun 14 15:10:24 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14436 )

Change subject: vty: command.c: Fix: multi-choice args are no longer passed incomplete to vty func
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14436/2/tests/tdef/tdef_vty_test_config_root.vty 
File tests/tdef/tdef_vty_test_config_root.vty:

https://gerrit.osmocom.org/#/c/14436/2/tests/tdef/tdef_vty_test_config_root.vty@a255 
PS2, Line 255: 
> Looks like a matching pattern: anything excluding 'timer'. […]
TBH no idea how that works, I was expecting somebody to comment on it :)

So iiuc I can write this and it should work?
"""
... !timer
timer tea T3 32
timer software T1 13
timer software T2 0
timer software T3 23
... !timer
"""



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14436
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I91b6621ac3d87fda5412a9b415e7bfb4736c8a9a
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Jun 2019 15:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/49aa935c/attachment.html>


More information about the gerrit-log mailing list