Change in ...libosmocore[master]: vty: command.c: Get rid of big indentation block

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jun 14 07:08:43 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14430 )

Change subject: vty: command.c: Get rid of big indentation block
......................................................................


Patch Set 2: Code-Review+1

(5 comments)

My warnings are not critical.

https://gerrit.osmocom.org/#/c/14430/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/14430/2//COMMIT_MSG@11 
PS2, Line 11: Check against MAX argc is changed
Any reason to do it as a part of this change?


https://gerrit.osmocom.org/#/c/14430/2/src/vty/command.c 
File src/vty/command.c:

https://gerrit.osmocom.org/#/c/14430/2/src/vty/command.c@2299 
PS2, Line 2299: if (argc == CMD_ARGC_MAX)
This could be done at the beginning of the 'for' loop, so we would avoid code duplication.


https://gerrit.osmocom.org/#/c/14430/2/src/vty/command.c@2319 
PS2, Line 2319: ==
This cosmetic change is unrelated.


https://gerrit.osmocom.org/#/c/14430/2/src/vty/command.c@2447 
PS2, Line 2447: if (argc == CMD_ARGC_MAX)
Same here.


https://gerrit.osmocom.org/#/c/14430/2/src/vty/command.c@2467 
PS2, Line 2467: ==
This cosmetic change is unrelated.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1494014b1e77ce10950f7268a44d2d2091a6f2
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 14 Jun 2019 07:08:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/81afb0b1/attachment.html>


More information about the gerrit-log mailing list