Change in ...osmo-sgsn[master]: sgsn: Have authentication required on by default

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 13 17:24:11 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-sgsn/+/14445

to look at the new patch set (#2).

Change subject: sgsn: Have authentication required on by default
......................................................................

sgsn: Have authentication required on by default

Previous commit introduced command "authentication (optional|required)",
which is only meaningful if auth-policy is remote. Upon adding the cmd,
it changed the default logic for remote policy to not require
authentication, which broke TTCN3 tests because sgsn no longer tries to
authenticate the users.

Since it's actually good to enable authentication by default where
possible, let's enable it by default when on auth-policy remote.

In order to do so, let's simply not care about the value of variable
require_authentication if auth_policy is not REMOTE. As a result, we
drop parts of the previous patch and remove unneeded checks (which are
only partially useful based on order of commands during VTY read).

Fixes: 794f446a284ed1ac6d31eb79a8f4c874d66fc34e
Change-Id: Ic707a95af178b44f08809df3d3bc8354bf34273c
---
M doc/manuals/vty/sgsn_vty_reference.xml
M include/osmocom/sgsn/sgsn.h
M src/gprs/gprs_sgsn.c
M src/gprs/sgsn_vty.c
4 files changed, 11 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/45/14445/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14445
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic707a95af178b44f08809df3d3bc8354bf34273c
Gerrit-Change-Number: 14445
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/3be6330d/attachment.html>


More information about the gerrit-log mailing list