Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_PortType.ttcn: clarify and unify timeout messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 13 15:33:34 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420 )

Change subject: library/L1CTL_PortType.ttcn: clarify and unify timeout messages
......................................................................

library/L1CTL_PortType.ttcn: clarify and unify timeout messages

It's way more cleaner when you see:

  Timeout waiting for L1CTL_RACH_CONF

instead of:

  Timeout in RACH.

Change-Id: I25e8230c2e4b29b2583bf8954d0dedaa18e5d6ae
---
M library/L1CTL_PortType.ttcn
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn
index 7af680c..2423715 100644
--- a/library/L1CTL_PortType.ttcn
+++ b/library/L1CTL_PortType.ttcn
@@ -59,7 +59,7 @@
 				}
 			[] pt.receive { repeat; };
 			[] T.timeout {
-				setverdict(fail, "Timeout in FBSB") 
+				setverdict(fail, "Timeout waiting for L1CTL_FBSB_CONF");
 				mtc.stop;
 				};
 			}
@@ -74,7 +74,7 @@
 		[] pt.receive(tr_L1CTL_CCCH_MODE_CONF) { }
 		[] pt.receive { repeat; }
 		[] T.timeout {
-			setverdict(fail, "Timeout in CCH_MODE");
+			setverdict(fail, "Timeout waiting for L1CTL_CCCH_MODE_CONF");
 			mtc.stop;
 			}
 		}
@@ -93,7 +93,7 @@
 			[] pt.receive(tr_L1CTL_RACH_CONF) -> value rc { fn := rc.dl_info.frame_nr };
 			[] pt.receive { repeat; };
 			[] T.timeout {
-				setverdict(fail, "Timeout in RACH");
+				setverdict(fail, "Timeout waiting for L1CTL_RACH_CONF");
 				mtc.stop;
 				}
 		}
@@ -114,7 +114,7 @@
 			[] pt.receive(tr_L1CTL_RACH_CONF) -> value rc { fn := rc.dl_info.frame_nr };
 			[] pt.receive { repeat; };
 			[] T.timeout {
-				setverdict(fail, "Timeout in extended RACH");
+				setverdict(fail, "Timeout waiting for (extended) L1CTL_RACH_CONF");
 				mtc.stop;
 				}
 		}
@@ -168,7 +168,7 @@
 			};
 			[] pt.receive { repeat };
 			[] T.timeout {
-				setverdict(fail, "Timeout waiting for IMM ASS");
+				setverdict(fail, "Timeout waiting for TBF IMM ASS");
 				mtc.stop;
 				}
 		}
@@ -184,7 +184,7 @@
 			[] pt.receive(tr_L1CTL_TBF_CFG_CONF(is_uplink)) {}
 			[] pt.receive { repeat };
 			[] T.timeout {
-				setverdict(fail, "Timeout waiting for TBF-CFG.conf");
+				setverdict(fail, "Timeout waiting for L1CTL_TBF_CFG_CONF");
 				mtc.stop;
 				};
 		}
@@ -213,7 +213,7 @@
 			[] pt.receive(tr_L1CTL_MsgType(L1CTL_RESET_CONF)) { }
 			[] pt.receive { repeat; }
 			[] T.timeout {
-				setverdict(fail, "Timeout waiting for RESET.conf");
+				setverdict(fail, "Timeout waiting for L1CTL_RESET_CONF");
 				mtc.stop;
 				}
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I25e8230c2e4b29b2583bf8954d0dedaa18e5d6ae
Gerrit-Change-Number: 14420
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/ee29c5ba/attachment.htm>


More information about the gerrit-log mailing list