Change in ...osmo-bsc[master]: logging: introduce LOG_BTS and LOG_TRX and use it everywhere

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 13 15:04:13 UTC 2019


laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 )

Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere
......................................................................

logging: introduce LOG_BTS and LOG_TRX and use it everywhere

It's quite ugly to have manual "bts=%d" printf-statements all over
the BSC code.  Let's change this to use shared logging helper functions
all over the place, whenever we need to log something related to one
BTS or one TRX.

This can also help us as the first step to later add alternative logging
of BTS identities, e.g. by printing the Cell Global Identifier or
LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather
than its numeric bts number.  With this change in place, we can
introduce such changes at a single location in the code.

Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
---
M include/osmocom/bsc/debug.h
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/acc_ramp.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/chan_alloc.c
M src/osmo-bsc/e1_config.c
M src/osmo-bsc/lchan_select.c
M src/osmo-bsc/paging.c
9 files changed, 89 insertions(+), 105 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/14439/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/27969136/attachment.html>


More information about the gerrit-log mailing list