Change in ...libosmocore[master]: logging: Use reentrant ctime_r instead of ctime

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 13 13:20:26 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14429 )

Change subject: logging: Use reentrant ctime_r instead of ctime
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14429/2/src/logging.c 
File src/logging.c:

https://gerrit.osmocom.org/#/c/14429/2/src/logging.c@370 
PS2, Line 370: snprintf
> Hmm, I think I see a possible optimization: […]
Reminder: You are getting rid of a space there. I'll adapt it and re-submit.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I19ebf29a2f1fc855bb7d56766b338c7c3432dfd1
Gerrit-Change-Number: 14429
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Jun 2019 13:20:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/8ad5e0c8/attachment.html>


More information about the gerrit-log mailing list