Change in ...libosmocore[master]: vty: command.c: Fix is_cmd_ambiguous() returning always 0

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 11 19:50:20 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/14422

to look at the new patch set (#2).

Change subject: vty: command.c: Fix is_cmd_ambiguous() returning always 0
......................................................................

vty: command.c: Fix is_cmd_ambiguous() returning always 0

inner block defined variable "enum match_type ret" was being masking
outter block variable "int ret = 0". The ret variable was being given
non zero values only inside the inner block, so that change was done on
the inner variable and not the outer one, which is returned.

Fixes: 5314c513f23688462d7f7937e5ae5e0d5cd4548e
Change-Id: Iec87d7db49a096d07e38ff8a060b923a52bfd6ba
---
M src/vty/command.c
M tests/tdef/tdef_vty_test_config_root.vty
M tests/vty/vty_transcript_test.vty
3 files changed, 14 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/14422/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iec87d7db49a096d07e38ff8a060b923a52bfd6ba
Gerrit-Change-Number: 14422
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190611/6bf8f0ef/attachment.html>


More information about the gerrit-log mailing list