Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jun 7 12:44:11 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 )

Change subject: rx_check_imei_req(): fix IMEI bounds checking
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14399/1/src/hlr.c 
File src/hlr.c:

https://gerrit.osmocom.org/#/c/14399/1/src/hlr.c@a483 
PS1, Line 483: 
AFAIR, gsm48_decode_bcd_number2() is not NULL-safe, so I would keep this check. Others can be safely removed, for sure.


https://gerrit.osmocom.org/#/c/14399/1/src/hlr.c@483 
PS1, Line 483: gsm48_decode_bcd_number2
Cosmetic, not critical: it would be good to store the returned value, and print it in the error message below. I find it helpful for trouble shooting.

  rc = gsm48_decode_bcd_number2(...);
  if (rc) { ... }



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I060a8db98fb882e4815d1709a5d85bc0143a73a6
Gerrit-Change-Number: 14399
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jun 2019 12:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190607/28ec1a23/attachment.html>


More information about the gerrit-log mailing list