Change in ...osmo-pcu[master]: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Jun 7 00:04:06 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14171 )

Change subject: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance
......................................................................


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.osmocom.org/#/c/14171/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/#/c/14171/1/src/gprs_bssgp_pcu.cpp@878 
PS1, Line 878: 	OSMO_ASSERT(bssgp_nsi);
> I'll drop this assert, as all calls should be guaranteed with an bssgp_nsi
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2aa53ea54e9352577f6280ad7b9d1d9da9f57eaf
Gerrit-Change-Number: 14171
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 00:04:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190607/a279618c/attachment.html>


More information about the gerrit-log mailing list