Change in ...osmo-ttcn3-hacks[master]: bts: Check if BTS_TRXC port is mapped before attempting UDP socket co...

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 5 08:26:49 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14379 )

Change subject: bts: Check if BTS_TRXC port is mapped before attempting UDP socket connect
......................................................................

bts: Check if BTS_TRXC port is mapped before attempting UDP socket connect

A large number of our tests is currently failing with
	BTS_Tests.ttcn:341 Dynamic test case error: IPL4 Test Port not mapped
which was introduced by Change-Id Ie7d311bf8f03bf9b1d29b5bb28ffad793f215fd1

Change-Id: Ia1ef4ac7dcfec137a8613bc49a7f312d81a86153
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e10d967..9371612 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -505,7 +505,7 @@
 	map(self:L1CTL, system:L1CTL);
 	f_connect_reset(L1CTL);
 
-	if (mp_bts_trxc_port != -1) {
+	if (mp_bts_trxc_port != -1 and BTS_TRXC.checkstate("Mapped")) {
 		f_init_trxc(BTS_TRXC, id, g_bts_trxc_conn_id);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14379
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ef4ac7dcfec137a8613bc49a7f312d81a86153
Gerrit-Change-Number: 14379
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190605/ed4a7065/attachment.html>


More information about the gerrit-log mailing list