Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

Hoernchen gerrit-no-reply at lists.osmocom.org
Tue Jun 4 15:46:46 UTC 2019


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 )

Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn 
File library/TRXC_CodecPort.ttcn:

https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn@31 
PS2, Line 31: 	log("Rx TRXC message: ", oct2char(pin.msg));
> doesn't the IPL4asp_PT log that by itself?  Or, if it doesn't, can't we simply enable related loggin […]
As far as this issue is concerned the existing logging was sufficient - it was just not obvious that it arrived at the wrong port. I don't think this change is necessary.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
Gerrit-Change-Number: 14372
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Harald Welte <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/f88fb670/attachment.html>


More information about the gerrit-log mailing list