Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 4 15:23:35 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 )

Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn 
File library/TRXC_CodecPort.ttcn:

https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn@31 
PS2, Line 31: 	log("Rx TRXC message: ", oct2char(pin.msg));
doesn't the IPL4asp_PT log that by itself?  Or, if it doesn't, can't we simply enable related logging of it by tuning the logging parameters?  This looks like something that we shouldn't [have to] do by hand.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
Gerrit-Change-Number: 14372
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/91f6206f/attachment.html>


More information about the gerrit-log mailing list