Change in ...osmo-bts[master]: bts-trx: trx_if.c: Introduce logging macro LOGPL1H

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 4 15:21:04 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14373 )

Change subject: bts-trx: trx_if.c: Introduce logging macro LOGPL1H
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14373/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/#/c/14373/1/src/osmo-bts-trx/trx_if.c@61 
PS1, Line 61: LOGPL1H
a) this is not "L1 handle" (which is bts model specific) but "phy instance" so something like LOGPPHI or the like would be more logical.

b) as phy_instance is common, the macro should be shared wih other backends so they can use it, too.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14373
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5b17a01638ade9a6c41da73e550d5947fa92f568
Gerrit-Change-Number: 14373
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/6c5540da/attachment.html>


More information about the gerrit-log mailing list