Change in ...osmo-ggsn[master]: gtp: Replace old pdp APIs with new ones with multi-gsn support

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 4 14:42:09 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 )

Change subject: gtp: Replace old pdp APIs with new ones with multi-gsn support
......................................................................


Patch Set 2:

> > Patch Set 2:
 > >
 > > this is about replacing API usage / API calls, right?  It's not
 > changing the actual API implementation?
 > 
 > Yes indeed, I prefered splitting into different commits, since
 > anyway I keep backwards compatibility. So first commit adds new
 > APIs (and change implementation of old ones). Then for each user of
 > the API, I add a commit with changes to move to use the new API
 > (libgtp, osmo-ggsn, sgsnemu, osmo-sgsn).

my point is that the commit log message does not reflect that it's about API usage.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14297
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibf56a063f01d1f95a2a3271416da6e062e85fdfa
Gerrit-Change-Number: 14297
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jun 2019 14:42:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/27a7cb57/attachment.html>


More information about the gerrit-log mailing list