Change in ...osmo-bsc[master]: vty: adjust config name for unit-id

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 4 11:54:15 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14365 )

Change subject: vty: adjust config name for unit-id
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/14365/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/14365/1/src/osmo-bsc/bsc_vty.c@900 
PS1, Line 900: unit_id
This change still doesn't solve the problem of inconsistency. OsmoBTS is using 'ipa unit-id', while here it's 'ipa unit_id'. Let's stick to 'ipa unit-id', so there would be no need to change OsmoBTS.


https://gerrit.osmocom.org/#/c/14365/1/src/osmo-bsc/bsc_vty.c@905 
PS1, Line 905: ip.access rsl-ip
Since we are moving to 'ipa', let's do it here too.


https://gerrit.osmocom.org/#/c/14365/1/src/osmo-bsc/bsc_vty.c@908 
PS1, Line 908: ip.access stream_id
Most likely, same here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ide5ceb5db7403a70313405752579e30d7bb94eac
Gerrit-Change-Number: 14365
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 11:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/610d4e05/attachment.html>


More information about the gerrit-log mailing list