Change in ...libosmocore[master]: lapdm: Allow user to specify T200 values; Use correct N200 values

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 4 11:08:01 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14339 )

Change subject: lapdm: Allow user to specify T200 values; Use correct N200 values
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c 
File src/gsm/lapdm.c:

https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c@163 
PS3, Line 163: int i = 0;
Doesn't this cause compiler warnings like "... only allowed in C99 mode"?


https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c@171 
PS3, Line 171: \ref
Let's avoid such references in the new code.


https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c@218 
PS3, Line 218: \ref
same


https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c@219 
PS3, Line 219: \ref
same


https://gerrit.osmocom.org/#/c/14339/3/src/gsm/lapdm.c@227 
PS3, Line 227: get_n200_dcch
Should we at least print some warning if the result would be -1?
Or is this value expected by subsequent calls?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I90fdc4dd4720d4e02213197c894eb0a55a39158c
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 11:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/0f85a4fa/attachment.html>


More information about the gerrit-log mailing list