Change in ...osmo-msc[master]: db_sms_test: Remove libdbi expected driver load errors

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 4 09:08:35 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14356 )

Change subject: db_sms_test: Remove libdbi expected driver load errors
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14356/1/tests/testsuite.at 
File tests/testsuite.at:

https://gerrit.osmocom.org/#/c/14356/1/tests/testsuite.at@23 
PS1, Line 23: 2>&1
> nice find!
autotest doesn't seem to like it. I changed the line to:
AT_CHECK([$abs_top_builddir/tests/db_sms/db_sms_test 2> >(grep -v "Failed to load driver")], [], [expout], [experr])

(I know it's not exactly the same I had before, just a simplified form)

But then running tests fail:
"""
  3: db_sms_test                                    osmo-msc/tests/testsuite.dir/at-groups/3/test-source: line 14: syntax error near unexpected token `>'
osmo-msc/tests/testsuite.dir/at-groups/3/test-source: line 14: `( $at_check_trace; $abs_top_builddir/tests/db_sms/db_sms_test 2> >(grep -v "Failed to load driver")'
testsuite: WARNING: unable to parse test group: 3
testsuite: WARNING: A failure happened in a test group before any test could be
testsuite: WARNING: run. This means that test suite is improperly designed.  Please
testsuite: WARNING: report this failure to <openbsc at lists.osmocom.org>.
 FAILED (testsuite.at:19)
"""

It looks like it doesn't like having parentheses in there. I tried scaping them wiht "\(", but didn't work.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I06dfdc5a7415a4d3b34a3b25f11c8abda1a63f92
Gerrit-Change-Number: 14356
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 09:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: Harald Welte <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190604/4d272064/attachment.html>


More information about the gerrit-log mailing list