Change in ...osmo-msc[master]: db_sms_test: Do not print exact memcmp result

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 3 19:42:18 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14357 )

Change subject: db_sms_test: Do not print exact memcmp result
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14357/1/tests/db_sms/db_sms_test.c 
File tests/db_sms/db_sms_test.c:

https://gerrit.osmocom.org/#/c/14357/1/tests/db_sms/db_sms_test.c@360 
PS1, Line 360: (diff=%d/%zu)
Ok, so now it does not make sense to print this part. Feel free to remove it completely.


https://gerrit.osmocom.org/#/c/14357/1/tests/db_sms/db_sms_test.ok 
File tests/db_sms/db_sms_test.ok:

https://gerrit.osmocom.org/#/c/14357/1/tests/db_sms/db_sms_test.ok@21 
PS1, Line 21: (diff=-1/256)
That's why: it looks more confusing than informative.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I771fb8f4fc56f337b16561d005ff1803a386d1c6
Gerrit-Change-Number: 14357
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/3140e57d/attachment.html>


More information about the gerrit-log mailing list