Change in ...osmo-bts[master]: vty: adjust config name for unit-id

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Jun 3 18:44:59 UTC 2019


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14359 )

Change subject: vty: adjust config name for unit-id
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1:
> 
> (2 comments)

https://gerrit.osmocom.org/#/c/14359/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/#/c/14359/1/src/common/vty.c@425 
PS1, Line 425: unit_id
> Maybe we should rather keep dash? […]
I didn't want to change both settings, and changing a _ to a - is kind of hard to spot.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14359
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ief6f23cc891a528d4295f7b0b85ff49bce299e8b
Gerrit-Change-Number: 14359
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/af3e1b6b/attachment.html>


More information about the gerrit-log mailing list