Change in ...osmo-bts[master]: vty: adjust config name for unit-id

Eric Wild gerrit-no-reply at lists.osmocom.org
Mon Jun 3 18:26:24 UTC 2019


Eric Wild has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14359


Change subject: vty: adjust config name for unit-id
......................................................................

vty: adjust config name for unit-id

Having different names for the same config setting is misleading, so
let's stick to the one used by osmo-bsc.

Change-Id: Ief6f23cc891a528d4295f7b0b85ff49bce299e8b
---
M src/common/vty.c
1 file changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/59/14359/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 1d25bfb..da32c54 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -269,7 +269,7 @@
 	vty_out(vty, " band %s%s", gsm_band_name(bts->band), VTY_NEWLINE);
 	if (bts->auto_band)
 		vty_out(vty, " auto-band%s", VTY_NEWLINE);
-	vty_out(vty, " ipa unit-id %u %u%s",
+	vty_out(vty, " ip.access unit_id %u %u%s",
 		bts->ip_access.site_id, bts->ip_access.bts_id, VTY_NEWLINE);
 	vty_out(vty, " oml remote-ip %s%s", bts->bsc_oml_host, VTY_NEWLINE);
 	vty_out(vty, " rtp jitter-buffer %u", bts->rtp_jitter_buf_ms);
@@ -422,7 +422,7 @@
 
 DEFUN(cfg_bts_unit_id,
       cfg_bts_unit_id_cmd,
-      "ipa unit-id <0-65534> <0-255>",
+      "ip.access unit_id <0-65534> <0-255>",
       "ip.access RSL commands\n"
       "Set the Unit ID of this BTS\n"
       "Site ID\n" "Unit ID\n")
@@ -437,6 +437,13 @@
 	return CMD_SUCCESS;
 }
 
+ALIAS_DEPRECATED(cfg_bts_unit_id,
+      cfg_bts_deprecated_unit_id_cmd,
+      "ipa unit-id <0-65534> <0-255>",
+      "ip.access RSL commands\n"
+      "Set the Unit ID of this BTS\n"
+      "Site ID\n" "Unit ID\n");
+      
 DEFUN(cfg_bts_band,
       cfg_bts_band_cmd,
       "band (450|GSM450|480|GSM480|750|GSM750|810|GSM810|850|GSM850|900|GSM900|1800|DCS1800|1900|PCS1900)",
@@ -1628,6 +1635,7 @@
 	install_element(CONFIG_NODE, &cfg_bts_cmd);
 	install_element(CONFIG_NODE, &cfg_vty_telnet_port_cmd);
 	install_element(BTS_NODE, &cfg_bts_unit_id_cmd);
+	install_element(BTS_NODE, &cfg_bts_deprecated_unit_id_cmd);
 	install_element(BTS_NODE, &cfg_bts_oml_ip_cmd);
 	install_element(BTS_NODE, &cfg_bts_rtp_bind_ip_cmd);
 	install_element(BTS_NODE, &cfg_bts_rtp_jitbuf_cmd);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14359
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ief6f23cc891a528d4295f7b0b85ff49bce299e8b
Gerrit-Change-Number: 14359
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Wild <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/f0e50112/attachment.html>


More information about the gerrit-log mailing list