Change in ...osmo-bts[master]: common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 3 15:08:12 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14335 )

Change subject: common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN
......................................................................

common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN

At the moment, bts_supports_cm() is only called on reception of
RSL Channel MODE MODIFY from the BSC. The idea is to check whether
the indicated RSL channel mode is supported by a BTS model.

RSL Channel MODE MODIFY message may indicate a channel in signalling
mode, i.e. GSM48_CMODE_SIGN, which has always been rejected so far.

Let's assume that signalling is always supported, as there is
no special BTS_FEAT_* definition to check that.

This change should make BTS_Tests.TC_rsl_modify_encr pass.

Change-Id: I8ea98a3eb9dc15a04f665596ee276883eb824b9a
---
M src/common/bts.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/bts.c b/src/common/bts.c
index 97e7a8b..596e5e0 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -744,6 +744,11 @@
 {
 	enum gsm_bts_features feature = _NUM_BTS_FEAT;
 
+	/* We assume that signalling support is mandatory,
+	 * there is no BTS_FEAT_* definition to check that. */
+	if (cm == GSM48_CMODE_SIGN)
+		return 1;
+
 	/* Before the requested pchan/cm combination can be checked, we need to
 	 * convert it to a feature identifier we can check */
 	switch (pchan) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14335
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8ea98a3eb9dc15a04f665596ee276883eb824b9a
Gerrit-Change-Number: 14335
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Eric Wild <ewild at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/8250e740/attachment.html>


More information about the gerrit-log mailing list