Change in ...osmo-ggsn[master]: ggsn: vty: Require ggsn param in <show pdp-context> cmd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 3 10:44:02 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14298 )

Change subject: ggsn: vty: Require ggsn param in <show pdp-context> cmd
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14298/2/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/14298/2/ggsn/ggsn_vty.c@767 
PS2, Line 767: ggsn NAME
> I think we should add a hidden / deprecated alias, because this change breaks backward compatibility […]
Indeed it does, but this type of command is not expected to be in VTY cfg files, since it's used to show information, and we don't use it in any TTCN3 test. So it does make sense to me in this case to make more mess in the code by adding a global ggsn variable and assign it to first created ggsn.

Still, it seems I need to update doc/manuals/vty/ggsn_vty_reference.xml (first find how to do it).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14298
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I8357e20076348c8ded5e9f5b8e7252566b0fbfea
Gerrit-Change-Number: 14298
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Jun 2019 10:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/d8704b70/attachment.htm>


More information about the gerrit-log mailing list