Change in ...osmo-hlr[master]: db_test: set timezone to work around mktime bug

osmith gerrit-no-reply at lists.osmocom.org
Mon Jun 3 09:42:12 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14351


Change subject: db_test: set timezone to work around mktime bug
......................................................................

db_test: set timezone to work around mktime bug

Apply workaround for db_test failure on ubuntu 19.04 in OBS. When the
timezone is set to UTC (default in OBS), and the glibc version is 2.29,
the test case is failing sometimes (not always) with the following
errors in the test log:

DAUC Cannot convert LU timestamp '2019-05-26 03:05:03' to time_t: Value too large for defined

Force the timezone to be CET when running the test, so it passes again.
I found this workaround in a Fedora bugreport [1], and tested with an
ubuntu 19.04 system running in docker, that setting the environment
variable like this makes the test pass 25 times in a row. Without it, it
fails every two or three times. Then I verified in my OBS namespace,
that the test also passes in OBS again.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1653340

Related: OS#4026
Change-Id: Ic8080ba1914bb364169ab0c563b132a4ab9a9aab
---
M tests/testsuite.at
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/51/14351/1

diff --git a/tests/testsuite.at b/tests/testsuite.at
index 70ae7ae..7d268d1 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -29,10 +29,12 @@
 AT_CHECK([$abs_top_builddir/tests/gsup_server/gsup_server_test], [], [expout], [experr])
 AT_CLEANUP
 
+# TZ=CET: workaround for glibc bug in mktime() (https://osmocom.org/issues/4026):
+# "Cannot convert LU timestamp '2019-05-26 03:05:03' to time_t: Value too large for defined data type"
 AT_SETUP([db])
 AT_KEYWORDS([db])
 cat $abs_srcdir/db/db_test.ok > expout
 cat $abs_srcdir/db/db_test.err > experr
 sqlite3 db_test.db < $abs_top_srcdir/sql/hlr.sql
-AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [experr])
+AT_CHECK([TZ=CET $abs_top_builddir/tests/db/db_test], [], [expout], [experr])
 AT_CLEANUP

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14351
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ic8080ba1914bb364169ab0c563b132a4ab9a9aab
Gerrit-Change-Number: 14351
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190603/1ae33cc4/attachment.html>


More information about the gerrit-log mailing list