Change in ...osmo-ttcn3-hacks[master]: lapdm: Rename 'dummy_CT' to more reasonable 'lapdm_test_CT'

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jun 2 21:28:46 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14326 )

Change subject: lapdm: Rename 'dummy_CT' to more reasonable 'lapdm_test_CT'
......................................................................

lapdm: Rename 'dummy_CT' to more reasonable 'lapdm_test_CT'

Change-Id: If72542f665a814bcda7c41120675a57ccf3407f4
---
M lapdm/L1CTL_Test.ttcn
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/lapdm/L1CTL_Test.ttcn b/lapdm/L1CTL_Test.ttcn
index 28bf25c..1922f70 100644
--- a/lapdm/L1CTL_Test.ttcn
+++ b/lapdm/L1CTL_Test.ttcn
@@ -4,12 +4,12 @@
 	import from LAPDm_RAW_PT all;
 	import from LAPDm_Types all;
 
-	type component dummy_CT {
+	type component lapdm_test_CT {
 		port LAPDm_PT LAPDM;
 		var lapdm_CT lapdm_component;
 	};
 
-	function f_init() runs on dummy_CT {
+	function f_init() runs on lapdm_test_CT {
 		/* create the LAPDm component */
 		lapdm_component := lapdm_CT.create;
 		/* connect our own LAPDM port to the LAPDM Service Provider of the LAPDm component */
@@ -23,7 +23,7 @@
 	}
 
 	/* master function establishing a dedicated radio channel (takes care of RACH/IMM.ASS handling) */
-	function f_establish_dcch() runs on dummy_CT {
+	function f_establish_dcch() runs on lapdm_test_CT {
 		var BCCH_tune_req tune_req := { arfcn := { false, 871 }, combined_ccch := true };
 		var DCCH_establish_req est_req := { ra := 23 };
 
@@ -33,7 +33,7 @@
 	}
 
 	/* helper function releasing dedicated radio channel physically (no Um signaling!) */
-	function f_release_dcch() runs on dummy_CT {
+	function f_release_dcch() runs on lapdm_test_CT {
 		var DCCH_release_req rel_req := {};
 		LAPDM.send(rel_req);
 	}
@@ -115,7 +115,7 @@
 	}
 
 
-	function f_test_sabm_results_in_ua(uint8_t sapi, boolean use_sacch, octetstring payload) runs on dummy_CT return boolean {
+	function f_test_sabm_results_in_ua(uint8_t sapi, boolean use_sacch, octetstring payload) runs on lapdm_test_CT return boolean {
 		var LAPDm_ph_data phd;
 		var boolean result := false;
 		timer T := 5.0;
@@ -135,7 +135,7 @@
 		return result;
 	}
 
-	testcase TC_sabm_ua_dcch_sapi0() runs on dummy_CT {
+	testcase TC_sabm_ua_dcch_sapi0() runs on lapdm_test_CT {
 		f_init();
 		if (not f_test_sabm_results_in_ua(0, false, 'FEFE'O)) {
 			setverdict(fail);
@@ -143,7 +143,7 @@
 		setverdict(pass);
 	}
 
-	testcase TC_sabm_ua_dcch_sapi0_nopayload() runs on dummy_CT {
+	testcase TC_sabm_ua_dcch_sapi0_nopayload() runs on lapdm_test_CT {
 		f_init();
 		if (f_test_sabm_results_in_ua(0, false, ''O)) {
 			setverdict(fail, "Initial SABM/UA must contain L3 payload but BTS accepts without");
@@ -151,7 +151,7 @@
 		setverdict(pass);
 	}
 
-	testcase TC_sabm_ua_dcch_sapi3() runs on dummy_CT {
+	testcase TC_sabm_ua_dcch_sapi3() runs on lapdm_test_CT {
 		f_init();
 		if (f_test_sabm_results_in_ua(3, false, 'FEFE'O)) {
 			setverdict(fail, "Initial SABM/UA must be on SAPI0, but BTS accepts SAPI=3");
@@ -159,7 +159,7 @@
 		setverdict(pass);
 	}
 
-	testcase TC_sabm_ua_dcch_sapi4() runs on dummy_CT {
+	testcase TC_sabm_ua_dcch_sapi4() runs on lapdm_test_CT {
 		f_init();
 		if (f_test_sabm_results_in_ua(4, false, 'FEFE'O)) {
 			setverdict(fail, "Initial SABM/UA must be on SAPI0, but BTS accepts SAPI=4");
@@ -167,7 +167,7 @@
 		setverdict(pass);
 	}
 
-	testcase TC_sabm_contention() runs on dummy_CT {
+	testcase TC_sabm_contention() runs on lapdm_test_CT {
 		var LAPDm_ph_data phd;
 		const octetstring payload := '0102030405'O;
 		const GsmSapi sapi := 0;
@@ -196,7 +196,7 @@
 
 	/* we test that a re-transmitted SABM with identical payload will result in the retransmission of a
 	  * UA. This is required during the contention resolution procedure as specified in 8.4.1.4 */
-	testcase TC_sabm_retransmit() runs on dummy_CT {
+	testcase TC_sabm_retransmit() runs on lapdm_test_CT {
 		const octetstring payload := '00FEFEDEADBEEF'O;
 		f_init();
 		if (not f_test_sabm_results_in_ua(0, false, payload)) {
@@ -208,7 +208,7 @@
 		setverdict(pass);
 	}
 
-	testcase TC_foo() runs on dummy_CT {
+	testcase TC_foo() runs on lapdm_test_CT {
 		var LapdmFrame lf;
 /*
 		var LapdmFrame lf := valueof(LAPDm_B_UA(0, ''O));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14326
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If72542f665a814bcda7c41120675a57ccf3407f4
Gerrit-Change-Number: 14326
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190602/bcf469b5/attachment.html>


More information about the gerrit-log mailing list