Change in ...osmo-ggsn[master]: ggsn: vty: Require ggsn param in <show pdp-context> cmd

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Jun 1 12:31:15 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14298 )

Change subject: ggsn: vty: Require ggsn param in <show pdp-context> cmd
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/14298/2/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/14298/2/ggsn/ggsn_vty.c@767 
PS2, Line 767: ggsn NAME
I think we should add a hidden / deprecated alias, because this change breaks backward compatibility.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14298
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I8357e20076348c8ded5e9f5b8e7252566b0fbfea
Gerrit-Change-Number: 14298
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 01 Jun 2019 12:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190601/61fc236d/attachment.html>


More information about the gerrit-log mailing list