Change in ...libosmocore[master]: lapdm: Don't truncate L3 payload at 200 bytes length

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jun 1 09:46:18 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14317


Change subject: lapdm: Don't truncate L3 payload at 200 bytes length
......................................................................

lapdm: Don't truncate L3 payload at 200 bytes length

3GPP TS 04.06 is quite clear that the [segmented] L3 payload can be as
long as 251 bytes.  Our libosmocore lapdm implementation truncated
already at 200 bytes :(

Change-Id: I6769986f27dda1d429ed7b2e32c36d34663acba9
Closes: OS#4035
---
M src/gsm/lapdm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/14317/1

diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index d76175b..f1651d6 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -136,7 +136,7 @@
 {
 	memset(dl, 0, sizeof(*dl));
 	dl->entity = entity;
-	lapd_dl_init(&dl->dl, 1, 8, 200);
+	lapd_dl_init(&dl->dl, 1, 8, 251); /* Section 5.8.5 of TS 04.06 */
 	dl->dl.reestablish = 0; /* GSM uses no reestablish */
 	dl->dl.send_ph_data_req = lapdm_send_ph_data_req;
 	dl->dl.send_dlsap = send_rslms_dlsap;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6769986f27dda1d429ed7b2e32c36d34663acba9
Gerrit-Change-Number: 14317
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190601/054b5e33/attachment.html>


More information about the gerrit-log mailing list