Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 31 20:45:06 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13312 )

Change subject: context: Add support for [per-thread] global talloc contexts
......................................................................


Patch Set 17:

(1 comment)

https://gerrit.osmocom.org/#/c/13312/17/src/context.c 
File src/context.c:

https://gerrit.osmocom.org/#/c/13312/17/src/context.c@36 
PS17, Line 36: 	memset(osmo_ctx, 0, sizeof(*osmo_ctx));
> This memset is not needed, can be removed.
well, talloc_named is not talloc_zero.  Sure, right now we just have two pointers that we overwrite two lines below, but I would still keep it on principle.  As the function is only called once there's no performance issue either.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3
Gerrit-Change-Number: 13312
Gerrit-PatchSet: 17
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: Max <suraev at alumni.ntnu.no>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Jul 2019 20:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/a04912b6/attachment.html>


More information about the gerrit-log mailing list