Change in ...osmo-bts[master]: osmo-bts-trx: Don't attemtp to adjust MS power if fixed

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 31 11:23:19 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15006 )

Change subject: osmo-bts-trx: Don't attemtp to adjust MS power if fixed
......................................................................

osmo-bts-trx: Don't attemtp to adjust MS power if fixed

If the BSC has instructed the BTS via RSL to not autonomously perform
MS power control, we are storing this in lchan->ms_power_ctrl.fixed.

However, osmo-bts-trx would simply ignore that flag in loops.c and
continue to compute new MS power values based on measurement results.

Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757
---
M src/osmo-bts-trx/loops.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index 380bac5..3fa2b3b 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -232,6 +232,9 @@
 					.lchan[l1sap_chan2ss(chan_nr)];
 	struct phy_instance *pinst = trx_phy_instance(l1t->trx);
 
+	if (lchan->ms_power_ctrl.fixed)
+	        return;
+
 	if (pinst->phy_link->u.osmotrx.trx_ms_power_loop)
 		ms_power_clock(lchan, chan_state);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757
Gerrit-Change-Number: 15006
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/7b516a2d/attachment.html>


More information about the gerrit-log mailing list