Change in ...osmo-bts[master]: osmo-bts-trx: Don't increment rssi_valid_count twice

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 31 11:23:10 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15005 )

Change subject: osmo-bts-trx: Don't increment rssi_valid_count twice
......................................................................

osmo-bts-trx: Don't increment rssi_valid_count twice

In the ms_power_val() function, don't increment the number of
valid RSSI values counter twice.

Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698
---
M src/osmo-bts-trx/loops.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index c17f548..380bac5 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -109,7 +109,6 @@
 	if (chan_state->meas.rssi_valid_count == ARRAY_SIZE(chan_state->meas.rssi))
 		return;
 	chan_state->meas.rssi[chan_state->meas.rssi_valid_count++] = rssi;
-	chan_state->meas.rssi_valid_count++;
 }
 
 /*! Process a single clock tick of the MS power control loop.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15005
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698
Gerrit-Change-Number: 15005
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/49ba85a5/attachment.htm>


More information about the gerrit-log mailing list