Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 31 10:56:24 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 )

Change subject: Handle SIP re-INVITEs
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/14994/3/src/sdp.c 
File src/sdp.c:

https://gerrit.osmocom.org/#/c/14994/3/src/sdp.c@35 
PS3, Line 35: sdp_mode_t sdp_mode(const sip_t *sip) {
an (at least) one line comment about what this function is doing) is customary.  Also, in terms of naming "sip_get_sdp_mode()" or "sip_{retrieve,obtain,determine}_sdp_mode()" would be more readable.


https://gerrit.osmocom.org/#/c/14994/3/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14994/3/src/sip.c@183 
PS3, Line 183: 		// TODO: Tell osmo-bts to stop sending RTP ?
> not quite the same thing as don't send RTP... I'll do further research on tihts.
well, the "correct" approach is probably to instruct the MSC-colocated MGW to put the SIP-side RTP connection in "recvonly" mode.  If osmo-sip-connector was talking MGCP directly to the MGW (as suggested in some discussions) that would be easy.  As it is not, we'd have to find a way to make that work via MNCC.  For sure the BTS/BSC or BSC-colocated MGW shouldn't be involved in it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed
Gerrit-Change-Number: 14994
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 31 Jul 2019 10:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/aee5edcb/attachment.html>


More information about the gerrit-log mailing list