Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 31 10:51:32 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )

Change subject: Add media mode parameter to sdp_create_file()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c 
File src/sdp.c:

https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c@191 
PS2, Line 191: 			mode_attribute = "";
> (I'm not sure why, but at least by convention) end each case in 'break;' […]
full ACK here to both comments.


https://gerrit.osmocom.org/#/c/14993/2/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14993/2/src/sip.c@389 
PS2, Line 389: 	sdp = sdp_create_file(leg, other, sdp_sendrecv);
> I can see that you are concerned about a change that might break something downstream.  […]
I also agree that a=sendrecv is implicit if absent.  But as neels states, it is a good idea to mention such a rather visible change in the commitlog.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2
Gerrit-Change-Number: 14993
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Jul 2019 10:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/a4d52c45/attachment.html>


More information about the gerrit-log mailing list