Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation

daniel gerrit-no-reply at lists.osmocom.org
Wed Jul 31 09:50:42 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 )

Change subject: common: trx_if.adoc: Improve documentation
......................................................................


Patch Set 5: Code-Review-1

(10 comments)

https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc 
File common/chapters/trx_if.adoc:

https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@5 
PS4, Line 5: The
> s/The/the/
Done


https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@162 
PS4, Line 162: 48-55:	TOA256
> ToA256 actually takes 2 octets.
Done


https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@184 
PS4, Line 184: TOA256: 8 bits (1 byte)::
> same here
Done


https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@208 
PS4, Line 208: RSSI
> It's called PWR.
Done


https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@226 
PS4, Line 226: RSSI: 8 bits (1 byte)::
             : Received Signal Strength Indication in -dBm, encoded without the negative sign.
> And AFAIR, it indicates Tx power attenuation wrt. the full scale.
Done


https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc 
File common/chapters/trx_if.adoc:

https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@10 
PS5, Line 10: channel
channels


https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@15 
PS5, Line 15: N
X


https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@16 
PS5, Line 16: N
X


https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@163 
PS5, Line 163: 	64-95:	...Payload...
What's the payload size here?
In line 187 it says 148 bytes for GSM, 444 bytes for EDGE.
Here it's 32...


https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@209 
PS5, Line 209: 	48-95:	...Payload...
See above comment

It's 48 bytes here, below specifies 148 or 444 bytes again.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018
Gerrit-Change-Number: 14938
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Jul 2019 09:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190731/af3ac2eb/attachment.html>


More information about the gerrit-log mailing list