Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Jul 30 17:17:17 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 )

Change subject: vty/vty.c: the command buffer can be accessed directly
......................................................................

vty/vty.c: the command buffer can be accessed directly

Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39
---
M src/vty/vty.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  neels: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/vty/vty.c b/src/vty/vty.c
index b1bb3f4..a96d86c 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -136,7 +136,7 @@
 }
 
 /* Authentication of vty */
-static void vty_auth(struct vty *vty, char *buf)
+static void vty_auth(struct vty *vty)
 {
 	char *passwd = NULL;
 	enum node_type next_node = 0;
@@ -170,10 +170,10 @@
 	if (passwd) {
 #ifdef VTY_CRYPT_PW
 		if (host.encrypt)
-			fail = strcmp(crypt(buf, passwd), passwd);
+			fail = strcmp(crypt(vty->buf, passwd), passwd);
 		else
 #endif
-			fail = strcmp(buf, passwd);
+			fail = strcmp(vty->buf, passwd);
 	} else
 		fail = 1;
 
@@ -417,13 +417,13 @@
 }
 
 /* Command execution over the vty interface. */
-static int vty_command(struct vty *vty, char *buf)
+static int vty_command(struct vty *vty)
 {
 	int ret;
 	vector vline;
 
 	/* Split readline string up into the vector */
-	vline = cmd_make_strvec(buf);
+	vline = cmd_make_strvec(vty->buf);
 
 	if (vline == NULL)
 		return CMD_SUCCESS;
@@ -689,10 +689,10 @@
 	switch (vty->node) {
 	case AUTH_NODE:
 	case AUTH_ENABLE_NODE:
-		vty_auth(vty, vty->buf);
+		vty_auth(vty);
 		break;
 	default:
-		ret = vty_command(vty, vty->buf);
+		ret = vty_command(vty);
 		if (vty->type == VTY_TERM)
 			vty_hist_add(vty);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39
Gerrit-Change-Number: 14975
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/a8eec9d5/attachment.html>


More information about the gerrit-log mailing list