Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Jul 30 17:14:20 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 )

Change subject: src/db.c: integrate SQLite3 with talloc allocator
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG@34 
PS3, Line 34: I've noticed a huge difference in heap usage footprint compared to
> difference in what way? which one is smaller?
It was in 2018 when I was trying to debug this odd bug. Basically I added a debug printf() to each (de|re|_)allocation wrapper. I don't remember which one was smaller, but with recent SQLite3 versions I did not notice any difference comparing the footprints of both malloc() and talloc(). What's even more interesting is that an old SQLite3 (e.g. 3.8.2) does pass 'make check' just fine...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7
Gerrit-Change-Number: 14939
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 17:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/646e7414/attachment.html>


More information about the gerrit-log mailing list