Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 30 15:05:15 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 )

Change subject: Handle SIP re-INVITEs
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c 
File src/sdp.c:

https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c@61 
PS1, Line 61: 		return sdp_sendrecv;
memleak of parser?


https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c@62 
PS1, Line 62: 	return sdp->sdp_media->m_mode;
memleak of parser?


https://gerrit.osmocom.org/#/c/14994/1/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14994/1/src/sip.c@175 
PS1, Line 175: 	char *sdp = NULL;
No need to set it to NULL, it's always set.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed
Gerrit-Change-Number: 14994
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 15:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/d6589d5d/attachment.html>


More information about the gerrit-log mailing list