Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 30 14:57:16 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )

Change subject: Add media mode parameter to sdp_create_file()
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c 
File src/sdp.c:

https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c@189 
PS1, Line 189: 	}
Just to make sure, no enum option missing? default? In that case, no need to initialize mode_attribute as NULL above.


https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c@206 
PS1, Line 206: 				mode_attribute ? mode_attribute : "");
simply set mode_attriubte = "" in default case then.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2
Gerrit-Change-Number: 14993
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 14:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/ac4981d2/attachment.html>


More information about the gerrit-log mailing list