Change in ...osmo-ggsn[master]: sgsnemu: Fix unaligned pointer access during ip/icmp checksum

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 30 07:52:20 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 )

Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c 
File sgsnemu/sgsnemu.c:

https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c@1285 
PS1, Line 1285: memcpy(&v16, p8, 2);
> To be honest, I'm not sure if that would be the same in this case. […]
Now that I see this is actualy computing the IP header checksum, what about using ggsn/checksum.c:ip_compute_csum() ? The function could be moved to a shared source file...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7
Gerrit-Change-Number: 14980
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 30 Jul 2019 07:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/b7f2c7e6/attachment.html>


More information about the gerrit-log mailing list