Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes

daniel gerrit-no-reply at lists.osmocom.org
Tue Jul 30 06:58:43 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 )

Change subject: configuration.adoc: Small fixes
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc@20 
PS1, Line 20: an
> https://english.stackexchange. […]
I checked this when writing my diploma thesis and it's about the sound of the word before the article.
So a source, an uninformed source, a uniformed (j-sound) source should all be correct as should an hour (h is silent). That's why I changed it to an EM-ES, but left a PEE-DEE-PEE context alone.

It seems that historic and hotel are exceptions - at least according to Merriam-Webster.

https://www.merriam-webster.com/words-at-play/is-it-a-or-an


https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc@255 
PS1, Line 255: in
             : order to save radio bandwith
> I would remove this part, because it duplicates the first sentence.
Thanks


https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc@293 
PS1, Line 293: again
> Again?
Well, it's disabled by default, so this command only has an effect if compression was previously enabled. Can you think of a different way to say it or do you think it's unnecessary?

On further though I guess it's unnecessary. Removed it.


https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc@337 
PS1, Line 337: again
> Again?
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558
Gerrit-Change-Number: 14981
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 06:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/d45b18b8/attachment.html>


More information about the gerrit-log mailing list