Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes

daniel gerrit-no-reply at
Tue Jul 30 06:58:43 UTC 2019

daniel has posted comments on this change. ( )

Change subject: configuration.adoc: Small fixes

Patch Set 1:

File doc/manuals/chapters/configuration.adoc: 
PS1, Line 20: an
> https://english.stackexchange. […]
I checked this when writing my diploma thesis and it's about the sound of the word before the article.
So a source, an uninformed source, a uniformed (j-sound) source should all be correct as should an hour (h is silent). That's why I changed it to an EM-ES, but left a PEE-DEE-PEE context alone.

It seems that historic and hotel are exceptions - at least according to Merriam-Webster. 
PS1, Line 255: in
             : order to save radio bandwith
> I would remove this part, because it duplicates the first sentence.
PS1, Line 293: again
> Again?
Well, it's disabled by default, so this command only has an effect if compression was previously enabled. Can you think of a different way to say it or do you think it's unnecessary?

On further though I guess it's unnecessary. Removed it. 
PS1, Line 337: again
> Again?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558
Gerrit-Change-Number: 14981
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Tue, 30 Jul 2019 06:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at>
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at>
Comment-In-Reply-To: laforge <laforge at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list