Change in[master]: Add control channels demappers tests

vvvelichkov gerrit-no-reply at
Mon Jul 29 19:00:54 UTC 2019

vvvelichkov has posted comments on this change. ( )

Change subject: Add control channels demappers tests

Patch Set 2:

File python/ 
PS1, Line 6:  
> ws
PS1, Line 142: b[  0], b[  1], b[  2], b[  3],
> Any benefits of having such sequential notation? […]
I like the test to be more explicit and probably I've copy-pasted it from one of the other tests 😊

I've change it to 

   self.assertEqual(b, list(dst.get_burst_data()))

which is one line and in case of a failure the assertEqual prints all bursts that are different and not only the first different burst as in the for loop variant. 
PS1, Line 172: assertEqual
> Same here, and even simpler.
PS1, Line 203: assertEqual
> Same here.
File python/ 
PS1, Line 24: bursts
> This list can also be generated using a for loop.
PS1, Line 150: timeslots
> Same here, just [0] * X, where X == len(timeslots).

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 2
Gerrit-Owner: vvvelichkov <vvvelichkov at>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: vvvelichkov <vvvelichkov at>
Gerrit-Comment-Date: Mon, 29 Jul 2019 19:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list