This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
vvvelichkov gerrit-no-reply at lists.osmocom.orgvvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 ) Change subject: Add control channels demappers tests ...................................................................... Patch Set 2: (6 comments) https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py File python/qa_gsm_bcch_ccch_demapper.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@6 PS1, Line 6: > ws Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@142 PS1, Line 142: b[ 0], b[ 1], b[ 2], b[ 3], > Any benefits of having such sequential notation? […] I like the test to be more explicit and probably I've copy-pasted it from one of the other tests 😊 I've change it to self.assertEqual(b, list(dst.get_burst_data())) which is one line and in case of a failure the assertEqual prints all bursts that are different and not only the first different burst as in the for loop variant. https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@172 PS1, Line 172: assertEqual > Same here, and even simpler. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@203 PS1, Line 203: assertEqual > Same here. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py File python/qa_gsm_demapper_data.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py@24 PS1, Line 24: bursts > This list can also be generated using a for loop. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py@150 PS1, Line 150: timeslots > Same here, just [0] * X, where X == len(timeslots). Done -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov <vvvelichkov at gmail.com> Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: vvvelichkov <vvvelichkov at gmail.com> Gerrit-Comment-Date: Mon, 29 Jul 2019 19:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190729/0c9e36e9/attachment.htm>