Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r...

laforge gerrit-no-reply at lists.osmocom.org
Mon Jul 29 18:33:54 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 )

Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/14968/1/contrib/remsim-apitool.py 
File contrib/remsim-apitool.py:

https://gerrit.osmocom.org/#/c/14968/1/contrib/remsim-apitool.py@65 
PS1, Line 65:     group.add_argument("-c", "--clients",  help="show clients         (GET /clients)",nargs='?',const="all",default=None)
Let's go for more "orthogonal" long commands, such as "--show-clients, --show-banks, --show-slotmaps and --create-slotmap, --show-all --delete-slotmap".  This way it's easier to extend in the future, where we might have other maps, or other things to delete.  Please change accordingly.

One might even do away with the short options (single-character ones) as they're more difficult to understand/read/memorize. This part is up to you.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7
Gerrit-Change-Number: 14968
Gerrit-PatchSet: 1
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 29 Jul 2019 18:33:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190729/17a847cc/attachment.html>


More information about the gerrit-log mailing list