Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp

laforge gerrit-no-reply at lists.osmocom.org
Mon Jul 29 18:28:57 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 )

Change subject: gsm0808_test: Fix wrong use of memcp
......................................................................


Patch Set 1: Code-Review+1

In such situations I would also stick with the simplicity of memcmp() and simply make sure the input data structures are always zero-initialized before.  But let's not argue about an unit test here...


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729
Gerrit-Change-Number: 14979
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 29 Jul 2019 18:28:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190729/f7fe0d16/attachment.html>


More information about the gerrit-log mailing list