Change in ...gr-gsm[master]: Add control channels demappers tests

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jul 26 12:34:12 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 )

Change subject: Add control channels demappers tests
......................................................................


Patch Set 1:

(6 comments)

https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py 
File python/qa_gsm_bcch_ccch_demapper.py:

https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@6 
PS1, Line 6:  
ws


https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@142 
PS1, Line 142: b[  0], b[  1], b[  2], b[  3],
Any benefits of having such sequential notation?
This could be also done in an imperative way:

  a = list(dst.get_burst_data())
  self.assertEqual(len(a), 108)
  for i in range(108):
    self.assertEqual(a[i], b[i])


https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@172 
PS1, Line 172: assertEqual
Same here, and even simpler.


https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py@203 
PS1, Line 203: assertEqual
Same here.


https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py 
File python/qa_gsm_demapper_data.py:

https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py@24 
PS1, Line 24: bursts
This list can also be generated using a for loop.


https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py@150 
PS1, Line 150: timeslots
Same here, just [0] * X, where X == len(timeslots).



-- 
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 1
Gerrit-Owner: vvvelichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 26 Jul 2019 12:34:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190726/67f1e129/attachment.html>


More information about the gerrit-log mailing list