Change in ...libosmocore[master]: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string()

laforge gerrit-no-reply at lists.osmocom.org
Fri Jul 26 05:23:57 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14935 )

Change subject: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string()
......................................................................

gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string()

Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e
---
M include/osmocom/gsm/gsm48.h
M src/gsm/gsm48.c
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm48.h b/include/osmocom/gsm/gsm48.h
index 786fbc9..7c68b1d 100644
--- a/include/osmocom/gsm/gsm48.h
+++ b/include/osmocom/gsm/gsm48.h
@@ -53,8 +53,7 @@
 uint8_t gsm48_generate_mid(uint8_t *buf, const char *id, uint8_t mi_type);
 
 /* Convert Mobile Identity (10.5.1.4) to string */
-int gsm48_mi_to_string(char *string, const int str_len,
-			const uint8_t *mi, const int mi_len);
+int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len);
 const char *gsm48_mi_type_name(uint8_t mi);
 const char *osmo_mi_name(const uint8_t *mi, uint8_t mi_len);
 char *osmo_mi_name_buf(char *buf, size_t buf_len, const uint8_t *mi, uint8_t mi_len);
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index c97337b..2d6deb5 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -741,8 +741,7 @@
  *           Depending on the MI type and amount of output buffer, this may return
  *           the nr of written bytes, or the written strlen(), or the snprintf()
  *           style strlen()-if-the-buffer-were-large-enough. */
-int gsm48_mi_to_string(char *string, const int str_len, const uint8_t *mi,
-		       const int mi_len)
+int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len)
 {
 	int rc;
 	uint8_t mi_type;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e
Gerrit-Change-Number: 14935
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190726/81661f38/attachment.html>


More information about the gerrit-log mailing list