Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 25 17:13:11 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 )

Change subject: src/db.c: integrate SQLite3 with talloc allocator
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/14939/2/src/db.c 
File src/db.c:

https://gerrit.osmocom.org/#/c/14939/2/src/db.c@88 
PS2, Line 88: #ifdef SQLITE_USE_TALLOC
I'd rather move all this block into its own file + header, in case somebody wants to quickly reuse it in other apps using talloc + sqlite (so they don't need to go look all along this file).


https://gerrit.osmocom.org/#/c/14939/2/src/db.c@426 
PS2, Line 426: #ifdef SQLITE_USE_TALLOC
Move this into the file and provide a public function on that file (header).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7
Gerrit-Change-Number: 14939
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190725/3f918b72/attachment.html>


More information about the gerrit-log mailing list