Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 25 10:51:10 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 )

Change subject: db_auc.c: verify hex key sizes read from DB
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c 
File src/db_auc.c:

https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c@78 
PS1, Line 78: int hexparse_stmt(void *dst, sqlite3_stmt *stmt, int col, const char *col_name, const char *imsi, int len_dst) {
* static missing in function?
* Why is dst a void* ptr? Isn't there something more descriptive? What's the type of aud2g->u.gsm.ki? uint8_t* ?
* Please put dst next-to len-dst (if I understand correct len_dst is the buffer size of dst).


https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c@82 
PS1, Line 82: 	len_col = sqlite3_column_bytes(stmt, col) / 2;
Why /2?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jul 2019 10:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190725/b227c75e/attachment.html>


More information about the gerrit-log mailing list