Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 24 20:39:57 UTC 2019


fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 )

Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional
......................................................................

gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional

Change-Id: I940d220a399166122f33e67a222dd572085e1401
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index b34659b..3ea3e59 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -118,7 +118,11 @@
 	/* read IMSI. if no IMSI exists, use first paging block (any paging),
 	 * because during attachment the IMSI might not be known, so the MS
 	 * will listen to all paging blocks. */
-	gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI));
+	if (TLVP_PRESENT(tp, BSSGP_IE_IMSI))
+	{
+		gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI),
+						       TLVP_LEN(tp, BSSGP_IE_IMSI));
+	}
 
 #if 0 /* Do not rely on this IE. TODO: make this configurable */
 	/* parse ms radio access capability */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401
Gerrit-Change-Number: 14922
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190724/e32cd02b/attachment.html>


More information about the gerrit-log mailing list