Change in ...osmo-bts[master]: trx: Use LOGPPHI instead of LOGP in some more messages

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 24 19:28:57 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14904 )

Change subject: trx: Use LOGPPHI instead of LOGP in some more messages
......................................................................

trx: Use LOGPPHI instead of LOGP in some more messages

This allows to clearly identify the phy instance owning those messages.

Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index b966bbe..6c6d5ad 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -107,22 +107,22 @@
 	buf[len] = '\0';
 
 	if (!!strncmp(buf, "IND CLOCK ", 10)) {
-		LOGP(DTRX, LOGL_NOTICE, "Unknown message on clock port: %s\n",
-			buf);
+		LOGPPHI(pinst, DTRX, LOGL_NOTICE,
+			"Unknown message on clock port: %s\n", buf);
 		return 0;
 	}
 
 	if (sscanf(buf, "IND CLOCK %u", &fn) != 1) {
-		LOGP(DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf);
+		LOGPPHI(pinst, DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf);
 		return 0;
 	}
 
-	LOGP(DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn);
+	LOGPPHI(pinst, DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn);
 
 	if (fn >= GSM_HYPERFRAME) {
 		fn %= GSM_HYPERFRAME;
-		LOGP(DTRX, LOGL_ERROR, "Indicated clock's FN is not wrapping "
-			"correctly, correcting to fn=%u\n", fn);
+		LOGPPHI(pinst, DTRX, LOGL_ERROR, "Indicated clock's FN is not "
+			"wrapping correctly, correcting to fn=%u\n", fn);
 	}
 
 	/* inform core TRX clock handling code that a FN has been received */
@@ -339,8 +339,8 @@
 
 	freq10 = gsm_arfcn2freq10(arfcn, 1); /* RX = uplink */
 	if (freq10 == 0xffff) {
-		LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n",
-		     arfcn & ~ARFCN_FLAG_MASK);
+		LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n",
+			arfcn & ~ARFCN_FLAG_MASK);
 		return -ENOTSUP;
 	}
 
@@ -358,8 +358,8 @@
 
 	freq10 = gsm_arfcn2freq10(arfcn, 0); /* TX = downlink */
 	if (freq10 == 0xffff) {
-		LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n",
-		     arfcn & ~ARFCN_FLAG_MASK);
+		LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n",
+			arfcn & ~ARFCN_FLAG_MASK);
 		return -ENOTSUP;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14904
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf
Gerrit-Change-Number: 14904
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190724/cf28c3c0/attachment.html>


More information about the gerrit-log mailing list